Skip to content

noarch run_exports#310

Merged
jjhelmus merged 2 commits into
conda-forge:masterfrom
isuruf:noarch_exports
Mar 4, 2020
Merged

noarch run_exports#310
jjhelmus merged 2 commits into
conda-forge:masterfrom
isuruf:noarch_exports

Conversation

@isuruf

@isuruf isuruf commented Feb 8, 2020

Copy link
Copy Markdown
Member

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jjhelmus

jjhelmus commented Mar 4, 2020

Copy link
Copy Markdown
Contributor

What will versions of conda-build prior to 3.18.12 do with this run_export. My reading of conda/conda-build#3868 is that the weak run_export will be applied in this case.

Not a reason to hold this up, just something to keep in mind.

It might be good to ensure that conda-build >=3.18.12 is used when building noarch packages if not all packages.

@jjhelmus jjhelmus merged commit ff3cf6d into conda-forge:master Mar 4, 2020
@isuruf

isuruf commented Mar 4, 2020

Copy link
Copy Markdown
Member Author

@jjhelmus, I agree. I'll add a condition to conda-forge-ci-setup.

I first thought of adding a check to conda-build to error out if an unknown run_exports type is used by a package, but that's not going to work with older conda-build releases, so I didn't. If you think it'll be useful for a new type of run_exports, I can send a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants